Skip to content

Commit

Permalink
Use current version of the phishing warning page (#16123)
Browse files Browse the repository at this point in the history
We now use the `latest` tag for the phishing warning page, we now use
the version that matches what we have in our manifest. This ensures
that our phishing warning e2e tests match the behaviour of the
production build, and it ensures that breaking changes to the phishing
warning page don't impact users in production.
  • Loading branch information
Gudahtt authored Oct 7, 2022
1 parent e72dfad commit 7279ea5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion development/build/scripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const bifyModuleGroups = require('bify-module-groups');
const { streamFlatMap } = require('../stream-flat-map');
const { BuildType } = require('../lib/build-type');
const { generateIconNames } = require('../generate-icon-names');
const phishingWarningManifest = require('../../node_modules/@metamask/phishing-warning/package.json');
const { BUILD_TARGETS, ENVIRONMENT } = require('./constants');
const { getConfig, getProductionConfig } = require('./config');
const {
Expand Down Expand Up @@ -112,7 +113,7 @@ function getPhishingWarningPageUrl({ config, testing }) {
if (!phishingWarningPageUrl) {
phishingWarningPageUrl = testing
? 'http://localhost:9999/'
: 'https://metamask.github.io/phishing-warning/latest/';
: `https://metamask.github.io/phishing-warning/v${phishingWarningManifest.version}/`;
}

// We add a hash/fragment to the URL dynamically, so we need to ensure it
Expand Down

0 comments on commit 7279ea5

Please sign in to comment.