Skip to content

Commit

Permalink
fix: Remove double padding on Snap home page (#26462)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Fixes a newly introduced issue where the Snap home page would have
double padding since all Snap UI's are wrapped in `<Container>` as of
f461e37,
the container component adds 16px of padding by itself.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26462?quickstart=1)
  • Loading branch information
FrederikBolding authored Aug 16, 2024
1 parent 2d63c0e commit 211cf40
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion ui/pages/snaps/snap-view/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

&__content {
@include design-system.screen-sm-max {
padding: 0 16px 16px 16px;
padding-top: 0;
}

&__permissions {
Expand Down
1 change: 1 addition & 0 deletions ui/pages/snaps/snap-view/snap-view.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ function SnapView() {
backgroundColor={BackgroundColor.backgroundDefault}
className="snap-view__content"
marginTop={4}
padding={showSettings ? 4 : 0}
>
{showSettings ? (
<SnapSettings
Expand Down

0 comments on commit 211cf40

Please sign in to comment.