Fixed e2e test

MetaMask · Nov 21, 2022 · 1f5db07 · 1f5db07
1 parent f8fbedb
commit 1f5db07
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/app/scripts/lib/personal-message-manager.js b/app/scripts/lib/personal-message-manager.js
@@ -82,15 +82,17 @@ export default class PersonalMessageManager extends EventEmitter {
    * @param {object} [req] - The original request object possibly containing the origin
    * @returns {promise} When the message has been signed or rejected
    */
-  addUnapprovedMessageAsync(msgParams, req) {
+  async addUnapprovedMessageAsync(msgParams, req) {
+    const msgId = await this.addUnapprovedMessage(msgParams, req);
+
     return new Promise((resolve, reject) => {
       if (!msgParams.from) {
         reject(
           new Error('MetaMask Message Signature: from field is required.'),
         );
         return;
       }
-      const msgId = this.addUnapprovedMessage(msgParams, req);
+
       this.once(`${msgId}:finished`, (data) => {
         switch (data.status) {
           case 'signed':

diff --git a/app/scripts/lib/typed-message-manager.js b/app/scripts/lib/typed-message-manager.js
@@ -83,9 +83,10 @@ export default class TypedMessageManager extends EventEmitter {
    * @param version
    * @returns {promise} When the message has been signed or rejected
    */
-  addUnapprovedMessageAsync(msgParams, req, version) {
+  async addUnapprovedMessageAsync(msgParams, req, version) {
+    const msgId = await this.addUnapprovedMessage(msgParams, req, version);
+
     return new Promise((resolve, reject) => {
-      const msgId = this.addUnapprovedMessage(msgParams, req, version);
       this.once(`${msgId}:finished`, (data) => {
         switch (data.status) {
           case 'signed':