Skip to content

Commit

Permalink
Set minimum browser version in manifest
Browse files Browse the repository at this point in the history
Set the minimum browser version supported in the extension manifest.
Currently we only ship the extension on Chrome and Firefox, so the
minimum version has been set for those two browsers.

Relates to #6805
  • Loading branch information
Gudahtt committed Jul 18, 2019
1 parent 83c2440 commit 1629bcb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
5 changes: 3 additions & 2 deletions app/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
},
"applications": {
"gecko": {
"id": "[email protected]"
"id": "[email protected]",
"strict_min_version": "53.0"
}
},
"default_locale": "en",
Expand Down Expand Up @@ -85,4 +86,4 @@
"*"
]
}
}
}
1 change: 1 addition & 0 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ gulp.task('manifest:chrome', function () {
return gulp.src('./dist/chrome/manifest.json')
.pipe(jsoneditor(function (json) {
delete json.applications
json.minimum_chrome_version = '58'
return json
}))
.pipe(gulp.dest('./dist/chrome', { overwrite: true }))
Expand Down

0 comments on commit 1629bcb

Please sign in to comment.