Merge branch 'develop' into 17191/onboarding-unit-tests

.circleci/scripts/release-bump-manifest-version.sh

@@ -19,7 +19,7 @@ fi
 printf '%s\n' 'Updating the manifest version if needed'
 
 version="${CIRCLE_BRANCH/Version-v/}"
-yarn version --no-git-tag-version --new-version "${version}"
+yarn version "${version}"
 
 if [[ -z $(git status --porcelain) ]]
 then

.yarnrc.yml

@@ -2,14 +2,16 @@ enableScripts: false
 
 enableTelemetry: false
 
+logFilters:
+  - code: YN0004
+    level: discard
+
 nodeLinker: node-modules
 
 plugins:
   - path: .yarn/plugins/@yarnpkg/plugin-allow-scripts.cjs
-    spec: 'https://raw.githubusercontent.com/LavaMoat/LavaMoat/main/packages/yarn-plugin-allow-scripts/bundles/@yarnpkg/plugin-allow-scripts.js'
+    spec: "https://raw.githubusercontent.com/LavaMoat/LavaMoat/main/packages/yarn-plugin-allow-scripts/bundles/@yarnpkg/plugin-allow-scripts.js"
+  - path: .yarn/plugins/@yarnpkg/plugin-version.cjs
+    spec: "@yarnpkg/plugin-version"
 
 yarnPath: .yarn/releases/yarn-3.2.4.cjs
-
-logFilters:
-  - code: YN0004
-    level: discard

coverage-targets.js

@@ -6,10 +6,10 @@
 // subset of files to check against these targets.
 module.exports = {
   global: {
-    branches: 22,
-    functions: 33.5,
+    branches: 50,
+    functions: 55,
     lines: 62.25,
-    statements: 41.75,
+    statements: 61.5,
   },
   transforms: {
     branches: 100,

nyc.config.js

@@ -0,0 +1,17 @@
+// nyc is our coverage reporter for mocha, and currently is collecting
+// coverage for .yarn folder. all of these are default excludes except the
+// .yarn/** entry. This entire file should be removable once we complete the
+// migration from mocha to jest in the app folder.
+module.exports = {
+  exclude: [
+    'coverage/**',
+    'packages/*/test/**',
+    'test/**',
+    'test{,-*}.js',
+    '**/*{.,-}test.js',
+    '**/__tests__/**',
+    '**/node_modules/**',
+    '**/babel.config.js',
+    '.yarn/**',
+  ],
+};