Polyfill replaceChildren #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
reviewed
Nov 23, 2021
Gudahtt
reviewed
Nov 23, 2021
util.js
Outdated
| @@ -7,6 +7,18 @@ const transform = require('gl-vec3/transformMat4'); | |||
|
|
|||
| const SVG_NS = 'http://www.w3.org/2000/svg'; | |||
|
|
|||
| // Taken from https://github.com/yuzhe-han/ParentNode-replaceChildren | |||
| // This is to support browsers that do not yet support `replaceChildren` | |||
| const replaceChildrenPolyfill = function (...addNodes) { | |||
There was a problem hiding this comment.
Nit: since this isn't being attached to Node.prototype.replaceChildren, it might be more correct to call this a "ponyfill".
Co-authored-by: Mark Stacey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaceChildrenis not supported on older browsers. See https://developer.mozilla.org/en-US/docs/Web/API/Element/replaceChildren#browser_compatibilityThis PR uses the polyfill from https://github.com/yuzhe-han/ParentNode-replaceChildren in cases where
replaceChildrenis unavailable.