-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to version 3.0.0 #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - found a couple of minor issues but overall this looks good.
CHANGELOG.md
Outdated
|
||
### Changed | ||
- Provide beta fox assets, demo, and meshJson option ([#50](https://github.com/MetaMask/logo/pull/50)) | ||
- Breaking: Update minimum Node version to 12 ([#46](https://github.com/MetaMask/logo/pull/46)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the formatting we use elsewhere is **BREAKING**:
, (or **(BREAKING)**
in some places, though I'm not sure what the parens are for 🤔 ) and usually we list the breaking change first in the category for emphasis.
CHANGELOG.md
Outdated
All notable changes to this project will be documented in this file. | ||
|
||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | ||
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
||
## [Unreleased] | ||
|
||
## [2.5.0] - 2020-08-19 | ||
## [3.0.0] - 2021-06-03 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: date update:
## [3.0.0] - 2021-06-03 | |
## [3.0.0] - 2021-06-08 |
|
No description provided.