Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 3.0.0 #52

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Update to version 3.0.0 #52

merged 1 commit into from
Jun 8, 2021

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Jun 3, 2021

No description provided.

@darkwing darkwing requested a review from a team as a code owner June 3, 2021 16:54
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@darkwing darkwing changed the title Update to version 2.6.0 Update to version 3.0.0 Jun 4, 2021
Gudahtt
Gudahtt previously approved these changes Jun 8, 2021
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - found a couple of minor issues but overall this looks good.

CHANGELOG.md Outdated

### Changed
- Provide beta fox assets, demo, and meshJson option ([#50](https://github.com/MetaMask/logo/pull/50))
- Breaking: Update minimum Node version to 12 ([#46](https://github.com/MetaMask/logo/pull/46))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the formatting we use elsewhere is **BREAKING**:, (or **(BREAKING)** in some places, though I'm not sure what the parens are for 🤔 ) and usually we list the breaking change first in the category for emphasis.

CHANGELOG.md Outdated
All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [2.5.0] - 2020-08-19
## [3.0.0] - 2021-06-03
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: date update:

Suggested change
## [3.0.0] - 2021-06-03
## [3.0.0] - 2021-06-08

@darkwing darkwing merged commit 69b467a into main Jun 8, 2021
@darkwing darkwing deleted the 2.6.0 branch June 8, 2021 15:18
@Gudahtt
Copy link
Member

Gudahtt commented Jun 8, 2021

A new version of the package @metamask/logo (3.0.0) was published at 2021-06-08T15:28:29.640Z from
[redacted]. The shasum of this package was f456a4ca6507005d3cd8b464a474f96e1adccc4d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants