Provide beta fox assets and demo #50
Conversation
darkwing
force-pushed
the
beta-logo-option
branch
from
5a458dd to
fa866a2
Compare
|
I'd probably rather we pass the mesh json into the constructor than have a beta flag, because this implies we package all meshes with every distribution, when instead we could be building towards a modularity where we can swap out logos. |
darkwing
force-pushed
the
beta-logo-option
branch
from
9a0daf5 to
bd38c22
Compare
|
Note that this is a breaking change as it no longer defaults to showing the standard fox logo -- it must now be provided via |
index.js
Outdated
| @@ -11,6 +10,10 @@ const { | |||
| module.exports = createLogo | |||
|
|
|||
| function createLogo (options = {}) { | |||
| if (!options.meshJson) { | |||
There was a problem hiding this comment.
Have you considered making fox.json the default meshJson rather than making it a strict requirement? That would let us release this as a non-breaking change (I think).
There was a problem hiding this comment.
We could, yes; I got the impression from @danfinlay's comment that we should keep this package as small as possible, but yeah, I'll go back to a default.
There was a problem hiding this comment.
Sounds good! Using fox.json by default shouldn't affect package size - it was still being included. Unless you meant to remove it.
Provides a
betaoption to define if we want that fox. Opendocs/beta/index.htmlto check it out.