Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Add async handle signature #55

Merged
merged 7 commits into from
Jul 27, 2020
Merged

Add async handle signature #55

merged 7 commits into from
Jul 27, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Jul 25, 2020 •
edited
Loading

  • Adds an async signature for RpcEngine.handle, so that you can do e.g. const result = await engine.handle(request).
    • Works for single and batch requests. Callback signature works the same as before.
  • Tests will be added in Full test coverage #52
  • Closes Add promise handler #31, which accomplished the same thing, but was never merged.

@rekmarks rekmarks requested a review from a team as a code owner July 25, 2020 05:34
This was referenced Jul 25, 2020
Merged
Merged
Gudahtt
Gudahtt previously approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/index.js Outdated Show resolved Hide resolved
@rekmarks rekmarks requested a review from Gudahtt July 27, 2020 20:54
Gudahtt
Gudahtt approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 9ffe19e into master Jul 27, 2020
@rekmarks rekmarks deleted the async-handle branch July 27, 2020 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @Gudahtt