This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
BREAKING: Use @metamask/utils #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
commented
May 16, 2022
| @@ -487,7 +441,7 @@ export class JsonRpcEngine extends SafeEventEmitter { | |||
| res: PendingJsonRpcResponse<unknown>, | |||
| isComplete: boolean, | |||
| ): void { | |||
| if (!('result' in res) && !('error' in res)) { | |||
| if (!hasProperty(res, 'result') && !hasProperty(res, 'error')) { | |||
There was a problem hiding this comment.
The replaced in checks.
mcmire
approved these changes
May 16, 2022
| export type JsonRpcMiddleware<T, U> = ( | ||
| req: JsonRpcRequest<T>, | ||
| res: PendingJsonRpcResponse<U>, | ||
| export type JsonRpcMiddleware<Params, Result> = ( |
There was a problem hiding this comment.
I like these type parameter names a lot better than T and U 👍🏻
| result?: T; | ||
| error?: Error | JsonRpcError; | ||
| } | ||
| export type PendingJsonRpcResponse<Result> = Omit< |
There was a problem hiding this comment.
Not suggesting any changes, but I wonder if this is type is right, considering that it seems that such a response can theoretically have both result and error.
There was a problem hiding this comment.
The type is meant to be used inside middleware functions and internally in JsonRpcEngine during request processing. It permits both, either, or neither property being present. Or did you mean something else?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace various utility types and functions with implementations copied over to
@metamask/utils. Functionality should be practically identical.The one possible deviation is that two
inchecks have been replaced withhasProperty, which does not walk the prototype chain. This should not be breaking for our purposes.