Use options bag parameters rather than MsgParams type #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signing and encryptuon functions all accepted a `MsgParams` parameter that included just a single property (`data`, the data to be signed). This pointless wrapper object around this single parameter complicated the type signatures of these functions. Instead, these functions now accept all parameters as one "options bag" parameter, and the `MsgParams` type has been removed. This makes the functions easier to use, as now it's not possible to enter the parameters in the wrong order. The related `SignedMsgParams` type has also been replaced in the same manner, for the same reasons.
|
The |
|
Looks good. thats a lot of test fixin 😅 would be nice to get rid of the |
shanejonas
approved these changes
Sep 13, 2021
Yep! It's awful. I'll have a second look for a workaround then remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signing and encryption functions all accepted a
MsgParamsparameter that included just a single property (data, the data to be signed). This pointless wrapper object around this single parameter complicated the type signatures of these functions.Instead, these functions now accept all parameters as one "options bag" parameter, and the
MsgParamstype has been removed. This makes the functions easier to use, as now it's not possible to enter the parameters in the wrong order.The related
SignedMsgParamstype has also been replaced in the same manner, for the same reasons.