Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename TypedDataUtils.sign to TypedDataUtils.eip712Hash #104

Merged
merged 2 commits into from
Jul 13, 2021
Merged

rename TypedDataUtils.sign to TypedDataUtils.eip712Hash #104

merged 2 commits into from
Jul 13, 2021

Conversation

ashwinYardi
Copy link
Contributor

No description provided.

@ashwinYardi ashwinYardi requested a review from a team as a code owner September 24, 2020 10:27
@ashwinYardi ashwinYardi mentioned this pull request Sep 24, 2020
Closed
Gudahtt
Gudahtt approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I think this is a great idea.

This is a breaking change, but we'll be preparing a new major release soon, so this is OK.

Gudahtt
Gudahtt reviewed Jul 13, 2021
View reviewed changes
src/index.ts
@@ -292,10 +292,10 @@ const TypedDataUtils = {
/**
* Signs a typed message as per EIP-712 and returns its keccak hash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these other inline docs could use improvements too, but I can do that in a separate PR

@Gudahtt Gudahtt merged commit 21da553 into MetaMask:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashwinYardi @Gudahtt