Typings don't compile

[mrwillis]

There are two issues

node_modules/eth-sig-util/index.d.ts:16:5 - error TS2411: Property 'EIP712Domain' of type 'ITypedField[] | undefined' is not assignable to string index type 'ITypedField[]'.

16     EIP712Domain?: Array<ITypedField>
       ~~~~~~~~~~~~

I don't recall EIP712Domain being optional in the Types in the spec.

Also

export interface ITypedValue {
  [key: string]: string | number | ITypedValue | ITypedValue[]
}

should also allow for string[] and number[]

[alcuadrado]

I'm experiencing the same issue. I believe it's impossible to distribute a TS package that has this one as a dependency.

[mrwillis]

Yes it is impossible.

@danfinlay is it possible to get a fix for this? I notice in general the typings do not include anything under TypedDataUtils namespace even though it is indeed exposed.

[danfinlay]

Sorry this has not been a high priority for me at the moment, I'll get to it when I can, or someone else can submit a PR for review.

[chentschel]

@danfinlay Its not possible to use the npm with typescript. Can u please review the PR?

[danfinlay]

I merged the open PR, fixed one of the two reported issues. Published as [email protected]

[chentschel]

@danfinlay thanks for the merge. As for the 2nd issue @mrwillis , wouldn't it be solved using a ITypedValue[] , defining ITypedValue[] as array of string, or number ?

export interface ITypedValue {
  [key: string]: string | number | ITypedValue | ITypedValue[]
}

[danfinlay]

I'm willing to merge a PR either removing index.d.ts or improving it.

[danfinlay]

Fine. Pending a proper typescript conversion, since I haven't had time to make sure this is all working right, and things clearly aren't, I've removed typedefs in [email protected].

I'm open to someone else doing the typescript conversion, and I may add a small gitcoin bounty to encourage it, and anyone else can too if the would value that feature.

[danfinlay]

Opened issue for actually converting to Typescript: #70