remove redundant allowlist entries #9632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
requested review from
a team,
409H,
AlexHerman1,
trn1ty and
ethphishingmaintainer1000
as code owners
legobeat
force-pushed
the
dedupe-allowlist
branch
3 times, most recently
from
166519d
to
4d2d515
Compare
legobeat
force-pushed
the
dedupe-allowlist
branch
from
4d2d515
to
7ead818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large deal of allowlist entries would not be blocked anyway. I guess some of these stem from days with a wider fuzzy setting, and that thins like https://github.com/MetaMask/eth-phishing-detect/pull/9413/files have slipped by from time to time. There are also some relics from past fuzzylist entries that are now removed (#4388 for example, which explains the ledgerwallet.com test change)
See #9610 for context and corresponding for blocklist entries.