Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Make new internal methods private #76

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Make new internal methods private #76

merged 1 commit into from
Dec 13, 2022

Conversation

adonesky1
Copy link
Contributor

Several utility methods were introduced as part of the transition to a new bip39 implementation: #67.

They should be marked private with a preceding underscore.

@adonesky1 adonesky1 requested a review from a team as a code owner December 13, 2022 16:35
@adonesky1 adonesky1 mentioned this pull request Dec 13, 2022
Merged
Gudahtt
Gudahtt approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 merged commit e46cde4 into main Dec 13, 2022
@adonesky1 adonesky1 deleted the make-methods-private branch December 13, 2022 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@legobeat legobeat Awaiting requested review from legobeat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adonesky1 @Gudahtt