Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Replace ethereumjs-wallet's hdkey with ethereum-cryptography's version #69

Merged
merged 9 commits into from
Dec 7, 2022

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Sep 20, 2022

Replaces ethereumjs-wallet implementation of hdkey  with one from ethereum-cryptography and adapts accordingly.
This is part of a broader effort to remove ethereumjs-wallet from our dependency graph for the purpose of reducing overall bundle size. ethereumjs-wallet is heavier and less well maintained than ethereum-cryptography/hdkey.

@socket-security
Copy link

socket-security bot commented Sep 20, 2022

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

@adonesky1 adonesky1 force-pushed the remove-ethereumjs-wallet branch 4 times, most recently from 5beb43c to 160c5de Compare December 6, 2022 18:32
@adonesky1 adonesky1 marked this pull request as ready for review December 6, 2022 19:15
@adonesky1 adonesky1 requested a review from a team as a code owner December 6, 2022 19:15
@adonesky1 adonesky1 changed the title working on removing need for ethereumjs-wallet Replace ethereumjs-wallet's hdkey with ethereum-cryptography's version Dec 6, 2022
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 merged commit caa0160 into main Dec 7, 2022
@adonesky1 adonesky1 deleted the remove-ethereumjs-wallet branch December 7, 2022 21:26
@Gudahtt Gudahtt mentioned this pull request Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants