This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 50
Replace ethereumjs-wallet
's hdkey
with ethereum-cryptography
's version
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
remove-ethereumjs-wallet
branch
from
September 20, 2022 21:27
fcdd966
to
54193b8
Compare
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
adonesky1
force-pushed
the
remove-ethereumjs-wallet
branch
4 times, most recently
from
December 6, 2022 18:32
5beb43c
to
160c5de
Compare
adonesky1
force-pushed
the
remove-ethereumjs-wallet
branch
from
December 6, 2022 19:08
160c5de
to
0f7d4fe
Compare
adonesky1
changed the title
working on removing need for ethereumjs-wallet
Replace Dec 6, 2022
ethereumjs-wallet
's hdkey
with ethereum-cryptography
's version
Gudahtt
reviewed
Dec 6, 2022
Co-authored-by: Mark Stacey <[email protected]>
Gudahtt
reviewed
Dec 6, 2022
Gudahtt
reviewed
Dec 6, 2022
Gudahtt
reviewed
Dec 6, 2022
Gudahtt
reviewed
Dec 6, 2022
Gudahtt
reviewed
Dec 7, 2022
adonesky1
force-pushed
the
remove-ethereumjs-wallet
branch
from
December 7, 2022 21:22
e937bf2
to
dec8e7c
Compare
Gudahtt
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
ethereumjs-wallet
implementation ofhdkey
with one fromethereum-cryptography
and adapts accordingly.This is part of a broader effort to remove
ethereumjs-wallet
from our dependency graph for the purpose of reducing overall bundle size.ethereumjs-wallet
is heavier and less well maintained than ethereum-cryptography/hdkey.