-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript and Jest config #3
Conversation
771bb3d
to
17a170f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it.
To be clear, I have not reviewed the meaning of even 5% of the rules in this repo, but support this effort without reservation. I also agree with all of the points outline by @whymarrh where he tagged me.
8b0cab9
to
1d05ba1
Compare
30ab202
to
eb0c88d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds a ESLint config for TypeScript and Jest. These can be used by extending them in client projects:[1]
You can see an example of this in action over at MetaMask/safe-event-emitter#1.
Important notes:
config/index.js
) and disable what we need to. I've created (Explicitly set all of the core ESLint rules #1) to track that work.