This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
draft css branch #704
Closed
draft css branch #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Excellent work on the tests! I think this PR is moving in a good direction. A few points below:
- Can we split this PR into two? One that tests the current CSS variables and another that adds the automation. I feel like they are two separate concerns.
- I agree that it makes sense to have a
utilsfolder insidesrc/. In the future, we may want to consolidate and move some of the functions fromdocs/there if they are used in tests or if it makes sense to do so. - In the automation PR, can we move
automation-scripts/brand-colors-css.jstoscripts/brand-colors-css.js? I know you are following conventions from other PRs, but I think having anautomation-scriptsfolder is redundant.
Comment on lines
+12
to
+19
| it('should match JSON values', () => { | ||
| for (const [colorGroup, shades] of Object.entries(jsonData)) { | ||
| for (const [shade, details] of Object.entries(shades)) { | ||
| const variableName = `${colorGroup}-${shade}`; | ||
| expect(cssVariables[variableName]).toBe(details.value); | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
Nice work added a console log to see what's happening here. LGTM!
| import jsonData from '../figma/brandColors.json'; | ||
|
|
||
| describe('CSS Variables', () => { | ||
| const cssFilePath = path.join(__dirname, 'generated-brand-colors.css'); |
There was a problem hiding this comment.
Can we test the current brand color stylesheet here? Additionally, we should add more tests for the light and dark themes. It's fine to do this in separate PRs if that makes more sense. It would also be good to have tests for typography.
Suggested change
| const cssFilePath = path.join(__dirname, 'generated-brand-colors.css'); | |
| const cssFilePath = path.join(__dirname, 'brand-colors.css'); |
| import path from 'path'; | ||
|
|
||
| import { getCssColorVariables } from '../../utils'; | ||
| import jsonData from '../figma/brandColors.json'; |
There was a problem hiding this comment.
Can we the first version of this PR test the current CSS variables against tokens.json?
Suggested change
| import jsonData from '../figma/brandColors.json'; | |
| import jsonData from '../figma/tokens.json'; |
| const cssVariables = getCssColorVariables(cssFilePath, 'brand-colors'); | ||
|
|
||
| it('should match JSON values', () => { | ||
| for (const [colorGroup, shades] of Object.entries(jsonData)) { |
There was a problem hiding this comment.
Updating to get brand colors from current token json
Suggested change
| for (const [colorGroup, shades] of Object.entries(jsonData)) { | |
| for (const [colorGroup, shades] of Object.entries( | |
| jsonData.global.brandColors, | |
| )) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist