This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Enhancements to CircleCI Script and Storybook Build #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
added
the
team-design-system
georgewrmarshall
force-pushed
the
fix/circle-ci-script
branch
from
7ba68e4 to
4b56da5
Compare
georgewrmarshall
changed the title
|
LGTM |
garrettbear
approved these changes
Jan 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request introduces several updates aimed at improving our CircleCI script and the discoverability of the Storybook build within the MetaMask bot comment. The script has been modified, it still builds a version of Storybook that includes the changes proposed in the current PR. However, instances referencing specific branches (e.g.,
develop) within the extension code base have been removed as well as the script to list all the changes to different files as it does not work as expected even in extension. This change reduces dependencies and potential confusion caused by branch-specific references. Enhancements have also been made to make the Storybook build more discoverable within the MetaMask bot comment. This improvement aims to streamline the review process by making it easier to locate and access the Storybook build.Initially this PR was supposed to fix the failing build but was resolved by @Gudahtt
Fixes: #584
Screenshot/Screencasts
Before
before.mov
After
after.mov
Manual testing steps