This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Adding shadows to design tokens #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [f662993]
|
georgewrmarshall
force-pushed
the
add/shadows
branch
from
f662993 to
a59dd02
Compare
Builds ready [a59dd02]
|
georgewrmarshall
force-pushed
the
add/shadows
branch
from
a59dd02 to
0aed8db
Compare
Builds ready [0aed8db]
|
Builds ready [465862f]
|
Builds ready [9abf171]
|
Cal-L
reviewed
May 12, 2022
Cal-L
reviewed
May 12, 2022
georgewrmarshall
force-pushed
the
add/shadows
branch
from
9abf171 to
ce4218b
Compare
georgewrmarshall
force-pushed
the
add/shadows
branch
from
bfdbc64 to
574667e
Compare
Builds ready [415cd4f]
|
Builds ready [c2597fd]
|
Builds ready [e29bded]
|
| <Story id="shadows-shadows--size" /> | ||
| </Canvas> | ||
|
|
||
| | Size | JS | CSS | |
There was a problem hiding this comment.
Do these token sizes and colors align in figma?
There was a problem hiding this comment.
Great question these should align with the tokens in Figma yes. I think Figma library is currently out of date @Akatori-Design
Builds ready [c55bf5a]
|
Builds ready [526d538]
|
Builds ready [e2538d7]
|
brianacnguyen
approved these changes
Jun 23, 2022
Builds ready [e26f734]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding shadows to design tokens.
The main architecture decisions for shadow tokens is to split up the size(x,y,blur,spread) and colors(neutral, primary, error/danger)
This adds 3 new colors to the colors:
Screenshots
References
https://www.figma.com/file/kdFzEC7xzSNw7cXteqgzDW/DS-Colors-%26-Shadows-%2F-Light-Theme?node-id=753%3A801
https://www.figma.com/file/rLKsoqpjyoKauYnFDcBIbO/DS-Colors-%26-Shadows-%2F-Dark-Theme?node-id=522%3A1022