-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump @metamask/eth-sig-util to latest #914
Conversation
6237e20
to
47c5214
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
47c5214
to
b553a84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! Just a few suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more suggestions, and I'm good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Looks good!
This reverts commit 49d3fe6.
- CHANGED: - Upgrades `eth-sig-util` (now `@metmask/eth-sig-util`) from v3.0.0 to v5.0.2. This upgrade contains several updates, including: - consolidates the recoverTypedSignature, recoverTypedSignature_v4, recoverTypedSignatureLegacy functions into one that switch on a new version argument. - reduces dependency burden, removing `secp256k1` and `keccak` via as dependencies by upgrading from `[email protected]` to its latest version `@ethereumjs/[email protected]` which uses lighter `noble` implementations for crypto functionality. Replaces `keccak` hashing with `keccak256` from `ethereum-cryptography/keccak`
- CHANGED: - Upgrades `eth-sig-util` (now `@metmask/eth-sig-util`) from v3.0.0 to v5.0.2. This upgrade contains several updates, including: - consolidates the recoverTypedSignature, recoverTypedSignature_v4, recoverTypedSignatureLegacy functions into one that switch on a new version argument. - reduces dependency burden, removing `secp256k1` and `keccak` via as dependencies by upgrading from `[email protected]` to its latest version `@ethereumjs/[email protected]` which uses lighter `noble` implementations for crypto functionality. Replaces `keccak` hashing with `keccak256` from `ethereum-cryptography/keccak`
CHANGED:
eth-sig-util
(now@metmask/eth-sig-util
) from v3.0.0 to v5.0.2. This upgrade contains several updates, including:secp256k1
andkeccak
via as dependencies by upgrading from[email protected]
to its latest version@ethereumjs/[email protected]
which uses lighternoble
implementations for crypto functionality. Replaceskeccak
hashing withkeccak256
fromethereum-cryptography/keccak