Feature: EIP747 watchAsset #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
brunobar79
approved these changes
Apr 3, 2019
| const releaseLock = await this.mutex.acquire(); | ||
| address = toChecksumAddress(address); | ||
| const { allTokens, tokens } = this.state; | ||
| const { networkType, selectedAddress } = this.config; | ||
| const newEntry: Token = { address, symbol, decimals }; | ||
| const newEntry: Token = { address, symbol, decimals, image }; |
There was a problem hiding this comment.
Just making sure that the state generated before this PR doesn’t break due to the new image property being added
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* allow token image * watch accept and reject asset * update doc * tests
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* allow token image * watch accept and reject asset * update doc * tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to handle EIP747 from
AssetsControllerand was mostly inspired mostly on how we handle transactions inTransactionController.For now these methods only support
Tokens, but was meant to easily add new types of assets in the future.