Transaction to smart contract #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 1221 1257 +36
Branches 141 156 +15
=====================================
+ Hits 1221 1257 +36
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 1221 1257 +36
Branches 141 156 +15
=====================================
+ Hits 1221 1257 +36
Continue to review full report at Codecov.
|
3 tasks
bitpshr
approved these changes
Mar 26, 2019
brunobar79
reviewed
Mar 26, 2019
src/TransactionController.ts
Outdated
| @@ -55,7 +63,7 @@ export interface Transaction { | |||
| * @property origin - Origin this transaction was sent from | |||
| * @property rawTransaction - Hex representation of the underlying transaction | |||
| * @property status - String status of this transaction | |||
| * @property time - Timestamp associated with this transaction | |||
| * @property toSmartContract - Whether transaction receipt is a smart contract | |||
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* add issmartcontract code * check if recipient is smart contract when fetching tx * add tests for changes * remove duplicated doc * dont request code if empty data * fix typo * fix condition
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* add issmartcontract code * check if recipient is smart contract when fetching tx * add tests for changes * remove duplicated doc * dont request code if empty data * fix typo * fix condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
toSmartContractattribute toTransactionMetaobject, it shows whether the transaction was sent to a smart contract or not, request that is being done only once when the tx is fetched.This avoids requesting this information (hitting infura) each time we render a transaction or having the audit issue caching this information.