Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removing the too wide codeowners rule #5015

Merged
merged 1 commit into from
Dec 2, 2024
Merged

chore: Removing the too wide codeowners rule #5015

merged 1 commit into from
Dec 2, 2024

Conversation

desi
Copy link
Contributor

@desi desi commented Dec 2, 2024 •
edited
Loading

Explanation

It has been discussed that having "Engineering" as codeowners on core repo is a bit too wide so we are removing that line.

References

n/a

Changelog

n/a

Checklist

N/A

@desi desi marked this pull request as ready for review December 2, 2024 22:55
@desi desi requested a review from a team as a code owner December 2, 2024 22:55
Gudahtt
Gudahtt approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@desi desi merged commit eb29045 into main Dec 2, 2024
122 checks passed
@desi desi deleted the chore/dm-remove-star-codeowner branch December 2, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desi @Gudahtt @cryptodev-2s