feat: enable smart transactions by default for new users #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan437
changed the title
7 tasks
packages/preferences-controller/src/PreferencesController.test.ts
Outdated
Show resolved
Hide resolved
dan437
force-pushed
the
enable-stx-for-new-users
branch
from
3adb7f5 to
5c2701e
Compare
infiniteflower
approved these changes
Nov 4, 2024
dan437
force-pushed
the
enable-stx-for-new-users
branch
from
5c2701e to
75e3675
Compare
pedronfigueiredo
approved these changes
Nov 6, 2024
dan437
force-pushed
the
enable-stx-for-new-users
branch
from
75e3675 to
dd2ed3f
Compare
Merged
dan437
added a commit
that referenced
this pull request
Nov 8, 2024
## Explanation New release with preferences-controller changes: #4885 ## References ## Changelog ## Checklist
github-merge-queue bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Nov 19, 2024
## **Description** This PR: - Removes the Smart Transactions Opt In modal - New users will have STX toggled on by default once we use this change from @metamask/preferences-controller: MetaMask/core#4885 ## **Related issues** Fixes: ## **Manual testing steps** 1. After installing the app a user will not see the STX opt in modal 2. In Advanced Settings Smart Transactions will be on. A user can turn them off if they want ## **Screenshots/Recordings** Smart Transactions enabled by default in Advanced settings for new users:  ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
sethkfman
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Nov 19, 2024
## **Description** This PR: - Removes the Smart Transactions Opt In modal - New users will have STX toggled on by default once we use this change from @metamask/preferences-controller: MetaMask/core#4885 ## **Related issues** Fixes: ## **Manual testing steps** 1. After installing the app a user will not see the STX opt in modal 2. In Advanced Settings Smart Transactions will be on. A user can turn them off if they want ## **Screenshots/Recordings** Smart Transactions enabled by default in Advanced settings for new users:  ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We want to enable smart transactions by default for new users.
References
Changelog
@metamask/preferences-controllerChecklist