Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove addNewAccountWithoutUpdate #4845

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Oct 24, 2024

Explanation

As updating identities in clients isn't a KeyringController responsibility anymore, the addNewAccountWithoutUpdate has no reason to exist here.

This method is currently used in one place, and there is an open PR to remove it.

References

Changelog

@metamask/keyring-controller

  • BREAKING: Remove addNewAccountWithoutUpdate

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mikesposito mikesposito marked this pull request as ready for review October 24, 2024 12:35
@mikesposito mikesposito requested review from a team as code owners October 24, 2024 12:35
cryptodev-2s
cryptodev-2s previously approved these changes Oct 24, 2024
@desi desi requested a review from a team October 25, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants