chore: remove addNewAccountWithoutUpdate
#4845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
As updating identities in clients isn't a
KeyringController
responsibility anymore, theaddNewAccountWithoutUpdate
has no reason to exist here.This method is currently used in one place, and there is an open PR to remove it.
References
addAccountWithoutUpdate
now updates thePreferencesController
state #3848Changelog
@metamask/keyring-controller
addNewAccountWithoutUpdate
Checklist