Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow overwriting built-in keyring builders #4362

Merged
merged 1 commit into from
Jun 4, 2024

Commits on Jun 3, 2024

  1. feat: Allow overwriting built-in keyring builders

    The KeyringController comes with two built-in keyrings: Simple and HD.
    Unfortunately it's impossible to overwrite these because when we build
    a new keyring, we look for the first keyring builder in the list that
    matches the type we want to build, and the built-in keyrings are always
    first.
    
    The order has been switched so that built-in keyrings come second,
    after custom keyring builders. This allows them to be overwritten.
    
    This makes it possible to test behavior that is specific to simple or
    HD keyrings. This is something that I wanted to do in the mobile
    repository.
    Gudahtt committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7d3db4e View commit details
    Browse the repository at this point in the history