Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update docs/contributing.md with yarn constraints --fix #4318

Merged
merged 1 commit into from
May 24, 2024

Conversation

dbrans
Copy link
Contributor

@dbrans dbrans commented May 24, 2024

Explanation

@Gudahtt wrote:

there is a missing step, you should run yarn constraints --fix and yarn to update package versions across the repository, and then to update the lockfile.

Unfortunately I don't think this step is documented at the moment. It was an unanticipated consequence of some recent-ish changes to the release tool and to how the monorepo is structured. We have plans to automate this step as well.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@dbrans dbrans requested a review from Gudahtt May 24, 2024 15:02
@dbrans dbrans marked this pull request as ready for review May 24, 2024 15:02
@dbrans dbrans requested a review from a team as a code owner May 24, 2024 15:02
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@dbrans dbrans merged commit c2d58c9 into main May 24, 2024
147 checks passed
@dbrans dbrans deleted the dbrans/docs-contrib branch May 24, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants