Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(keyring-controller): Bump @keystonehq/metamask-airgapped-keyring to ^0.14.1 #4277

Merged
merged 2 commits into from
May 14, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 13, 2024

Explanation

  • deps(keyring-controller): Bump @keystonehq/metamask-airgapped-keyring from ^0.13.1 to ^0.14.1
    • Updates @metamask/obs-store from v7 to v9
      • Removes dependency on readable-stream 2.x.
  • devDeps(keyring-controller): Bump @keystonehq/bc-ur-registry-eth from ^0.9.0 to ^0.19.0
    • Deduplicates from 2 instances of the package to 1
    • Removes instance of devDependency on ethereumjs-util

References

Changelog

@metamask/keyring-controller

  • FIXED: Bump @keystonehq/metamask-airgapped-keyring from ^0.13.1 to ^0.14.1

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@legobeat legobeat changed the title deps(keyring-controller): @keystonehq/metamask-airgapped-keyring@^0.1… deps(keyring-controller): Bump @keystonehq/metamask-airgapped-keyring to 0.14.0 May 13, 2024
@legobeat legobeat changed the title deps(keyring-controller): Bump @keystonehq/metamask-airgapped-keyring to 0.14.0 deps(keyring-controller): Bump @keystonehq/metamask-airgapped-keyring to ^0.14.0 May 13, 2024
Copy link

socket-security bot commented May 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@keystonehq/[email protected] None 0 0 B
npm/@metamask/[email protected] None 0 30.8 kB lgbot

🚮 Removed packages: npm/@keystonehq/[email protected]

View full report↗︎

Copy link

socket-security bot commented May 13, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat force-pushed the deps-keystone-metamask-keyring branch from e45fe81 to 783239e Compare May 13, 2024 06:59
@legobeat
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/[email protected]

new author ok

spidermans

@legobeat legobeat added the dependencies Pull requests that update a dependency file label May 13, 2024
@legobeat legobeat changed the title deps(keyring-controller): Bump @keystonehq/metamask-airgapped-keyring to ^0.14.0 deps(keyring-controller): Bump @keystonehq/metamask-airgapped-keyring to ^0.14.1 May 13, 2024
@legobeat legobeat marked this pull request as ready for review May 13, 2024 07:08
@legobeat legobeat requested a review from a team as a code owner May 13, 2024 07:08
@legobeat legobeat requested a review from Montoya May 13, 2024 10:34
@legobeat legobeat merged commit 624dba9 into MetaMask:main May 14, 2024
144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants