Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 146.0.0 #4232

Merged
merged 9 commits into from
Apr 30, 2024
Merged

Release 146.0.0 #4232

merged 9 commits into from
Apr 30, 2024

Conversation

kanthesha
Copy link
Contributor

Explanation

This release includes

Phishing Controller

  • Update to the pooling intervals
  • Bump controller-utils version to ~9.1.0
  • Bump TypeScript version to ~4.9.5

Base Controller

  • Bump TypeScript version to ~4.9.5
  • Fix misnamed parameter name

References

Changelog

@metamask/phishing-controller

  • : Updated pooling intervals, stalelist to 30 days and hotlist to 5 mins
  • : Bump TypeScript version to ~4.9.5

@metamask/base-controller

  • : Bump TypeScript version to ~4.9.5

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@kanthesha kanthesha changed the title Release base and phishing controllers Release 146.0.0 Apr 30, 2024
@kanthesha kanthesha marked this pull request as ready for review April 30, 2024 12:52
@kanthesha kanthesha requested a review from a team as a code owner April 30, 2024 12:52

### Fixed

- Fix misnamed parameter name ([#4108](https://github.com/MetaMask/core/pull/4108))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an internal parameter, so I think we can omit it from the changelog. It doesn't impact the API at all


### Changed

- Updated pooling intervals ([#4202](https://github.com/MetaMask/core/pull/4202))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo:

Suggested change
- Updated pooling intervals ([#4202](https://github.com/MetaMask/core/pull/4202))
- Updated polling intervals ([#4202](https://github.com/MetaMask/core/pull/4202))

or alternatively:

Suggested change
- Updated pooling intervals ([#4202](https://github.com/MetaMask/core/pull/4202))
- Changed lists refresh intervals ([#4202](https://github.com/MetaMask/core/pull/4202))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is been updated to

- Changed Stalelist and hotlist intervals ([#4202](https://github.com/MetaMask/core/pull/4202))

@mikesposito mikesposito mentioned this pull request Apr 30, 2024
@kanthesha kanthesha requested a review from a team as a code owner April 30, 2024 14:42
Gudahtt
Gudahtt previously approved these changes Apr 30, 2024
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions, but generally LGTM!

packages/phishing-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/phishing-controller/CHANGELOG.md Outdated Show resolved Hide resolved
@Gudahtt Gudahtt dismissed their stale review April 30, 2024 14:48

Needs a lockfile update

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 109ebe0 into main Apr 30, 2024
139 checks passed
@Gudahtt Gudahtt deleted the release/146.0.0 branch April 30, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Phishing Controller Pooling interval changes
4 participants