-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 146.0.0 #4232
Release 146.0.0 #4232
Conversation
|
||
### Fixed | ||
|
||
- Fix misnamed parameter name ([#4108](https://github.com/MetaMask/core/pull/4108)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an internal parameter, so I think we can omit it from the changelog. It doesn't impact the API at all
|
||
### Changed | ||
|
||
- Updated pooling intervals ([#4202](https://github.com/MetaMask/core/pull/4202)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo:
- Updated pooling intervals ([#4202](https://github.com/MetaMask/core/pull/4202)) | |
- Updated polling intervals ([#4202](https://github.com/MetaMask/core/pull/4202)) |
or alternatively:
- Updated pooling intervals ([#4202](https://github.com/MetaMask/core/pull/4202)) | |
- Changed lists refresh intervals ([#4202](https://github.com/MetaMask/core/pull/4202)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is been updated to
- Changed Stalelist and hotlist intervals ([#4202](https://github.com/MetaMask/core/pull/4202))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of suggestions, but generally LGTM!
Co-authored-by: Mark Stacey <[email protected]>
Co-authored-by: Mark Stacey <[email protected]>
Co-authored-by: Mark Stacey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Explanation
This release includes
Phishing Controller
~9.1.0
~4.9.5
Base Controller
~4.9.5
References
Changelog
@metamask/phishing-controller
~4.9.5
@metamask/base-controller
~4.9.5
Checklist