fix: add HD keyring check to persistAllKeyrings
#4168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! I was about to approve, but I noticed that there are now conflicts |
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 17, 2024
A patch has been added for the `@metamask/keyring-controller` package that will prevent the HD keyring from being removed. This is a precautionary change, see MetaMask/mobile-planning#1507 for additional details. This is a port of this PR: MetaMask/core#4168 Here is the same patch on mobile: MetaMask/metamask-mobile#9092
7 tasks
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 17, 2024
A patch has been added for the `@metamask/keyring-controller` package that will prevent the HD keyring from being removed. This is a precautionary change, see MetaMask/mobile-planning#1507 for additional details. This is a port of this PR: MetaMask/core#4168 Here is the same patch on mobile: MetaMask/metamask-mobile#9092
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 17, 2024
A patch has been added for the `@metamask/keyring-controller` package that will prevent the HD keyring from being removed. This is a precautionary change, see MetaMask/mobile-planning#1507 for additional details. This is a port of this PR: MetaMask/core#4168 Here is the same patch on mobile: MetaMask/metamask-mobile#9092
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 17, 2024
A patch has been added for the `@metamask/keyring-controller` package that will prevent the HD keyring from being removed. This is a precautionary change, see MetaMask/mobile-planning#1507 for additional details. This is a port of this PR: MetaMask/core#4168 Here is the same patch on mobile: MetaMask/metamask-mobile#9092
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 18, 2024
A patch has been added for the `@metamask/keyring-controller` package that will prevent the HD keyring from being removed. This is a precautionary change, see MetaMask/mobile-planning#1507 for additional details. This is a port of this PR: MetaMask/core#4168 Here is the same patch on mobile: MetaMask/metamask-mobile#9092
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 18, 2024
A patch has been added for the `@metamask/keyring-controller` package that will prevent the HD keyring from being removed. This is a precautionary change, see MetaMask/mobile-planning#1507 for additional details. This is a port of this PR: MetaMask/core#4168 Here is the same patch on mobile: MetaMask/metamask-mobile#9092
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 18, 2024
## **Description** A patch has been added for the `@metamask/keyring-controller` package that will prevent the HD keyring from being removed. This is a precautionary change, see MetaMask/mobile-planning#1507 for additional details. [](https://codespaces.new/MetaMask/metamask-extension/pull/24096?quickstart=1) ## **Related issues** This is a port of this PR: MetaMask/core#4168 Here is the same patch on mobile: MetaMask/metamask-mobile#9092 ## **Manual testing steps** This is a precaution against a bug that probably does not exist. We don't have reproduction steps. However, here are some use cases related to this area of code, which we can test to ensure nothing has broken: * Lock and unlock the wallet * Restart the extension then unlock it again * Add a new account, lock the wallet, restart the extension, then check to ensure the new account is still present. ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 18, 2024
## **Description** A patch has been added for the `@metamask/keyring-controller` package that will prevent the HD keyring from being removed. This is a precautionary change, see MetaMask/mobile-planning#1507 for additional details. [](https://codespaces.new/MetaMask/metamask-extension/pull/24096?quickstart=1) ## **Related issues** This is a port of this PR: MetaMask/core#4168 Here is the same patch on mobile: MetaMask/metamask-mobile#9092 ## **Manual testing steps** This is a precaution against a bug that probably does not exist. We don't have reproduction steps. However, here are some use cases related to this area of code, which we can test to ensure nothing has broken: * Lock and unlock the wallet * Restart the extension then unlock it again * Add a new account, lock the wallet, restart the extension, then check to ensure the new account is still present. ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 25, 2024
## **Description** A patch has been added for the `@metamask/keyring-controller` package that will prevent the HD keyring from being removed. This is a precautionary change, see MetaMask/mobile-planning#1507 for additional details. [](https://codespaces.new/MetaMask/metamask-extension/pull/24096?quickstart=1) ## **Related issues** This is a port of this PR: MetaMask/core#4168 Here is the same patch on mobile: MetaMask/metamask-mobile#9092 ## **Manual testing steps** This is a precaution against a bug that probably does not exist. We don't have reproduction steps. However, here are some use cases related to this area of code, which we can test to ensure nothing has broken: * Lock and unlock the wallet * Restart the extension then unlock it again * Add a new account, lock the wallet, restart the extension, then check to ensure the new account is still present. ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/24096?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds a check to the
persistAllKeyringsmethod to avoid removing the HD Key Tree keyring.References
Related to https://github.com/MetaMask/mobile-planning/issues/1507
Changelog
@metamask/keyring-controllerpersistAllKeyringsChecklist