Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linea sepolia network support #3995

Merged
merged 11 commits into from
Mar 8, 2024
Merged

Conversation

VGau
Copy link
Contributor

@VGau VGau commented Feb 28, 2024

Explanation

A new Linea Sepolia network will be added to MetaMask soon. This PR adds the Linea Sepolia network to several packages:

  • controller-utils
  • network-controller
  • name-controller
  • preferences-controller
  • transaction-controller

References

Changelog

@metamask/name-controller

  • ADDED: Add Linea Sepolia chain ID to ETHERSCAN_SUPPORTED_NETWORKS constant.

@metamask/controller-utils

  • ADDED: Add Linea Sepolia network support

@metamask/network-controller

  • CHANGED: Bump @metamask/eth-json-rpc-infura from ^9.0.0 to ^9.1.0

@metamask/preferences-controller

  • ADDED: Add Linea Sepolia network support

@metamask/transaction-controller

  • ADDED: Add Linea Sepolia network support

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

…nd in network/name/preferences/transaction controllers packages
@VGau VGau requested a review from a team as a code owner February 28, 2024 17:23
Copy link

socket-security bot commented Feb 28, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/@metamask/[email protected]
Unstable ownership npm/@metamask/[email protected]

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

socket-security bot commented Mar 4, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +485 147 MB mcmire

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@mcmire
Copy link
Contributor

mcmire commented Mar 5, 2024

Hi @VGau, would you mind filling out the Changelog section? This helps us prepare new releases. You can see an example of what this section should look like here: #3948. You can also see what this looks like for multiple packages here: #3954. There is also a comment in the PR description itself when you go to edit you will see for more on that section.

mcmire
mcmire previously approved these changes Mar 5, 2024
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a note about the Changelog section in the PR description, but this looks good!

@VGau
Copy link
Contributor Author

VGau commented Mar 5, 2024

I left a note about the Changelog section in the PR description, but this looks good!

I updated the Changelog section. Thanks.

mcmire
mcmire previously approved these changes Mar 7, 2024
@mcmire
Copy link
Contributor

mcmire commented Mar 8, 2024

Socket warnings above are fine — @metamask/eth-json-rpc-infura is our package.

@mcmire mcmire merged commit 4e03239 into main Mar 8, 2024
138 of 139 checks passed
@mcmire mcmire deleted the feat/add-linea-sepolia-network branch March 8, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants