fix: add wildcard for custody keyring #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
reviewed
Feb 7, 2024
legobeat
requested review from
gantunesr,
danroc,
a team,
AlexJupiter,
owencraston,
plasmacorral,
mikesposito and
k-g-j
|
Do you think instead of this method keyrings should have a default account name and provide a get method to expose it? That way we wouldn't need to worry about this mapping and we can make it part of the API |
Its a good idea, lets plan this out when we refactor the keyrings to use the keyring api |
MajorLift
pushed a commit
that referenced
this pull request
Feb 16, 2024
## Explanation This pr resolves the special case when passing a custody keyring type to the function keyringTypeToName. ## References Fixes: MetaMask/accounts-planning#233 ## Changelog ### `@metamask/keyring-controller` - **CHANGED**: Custody keyring type. ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Gustavo Antunes <[email protected]>
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This pr resolves the special case when passing a custody keyring type to the function keyringTypeToName.
References
Fixes: https://github.com/MetaMask/accounts-planning/issues/233
Changelog
@metamask/keyring-controllerChecklist