feat(preferences-controller): Convert to BaseControllerV2 #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
convert-preferences-controller-to-base-controller-v2
branch
2 times, most recently
from
a2d6420 to
ab2cb6c
Compare
Gudahtt
force-pushed
the
clean-up-preferences-controller-types
branch
from
320415c to
0ffc8af
Compare
3 tasks
Gudahtt
force-pushed
the
convert-preferences-controller-to-base-controller-v2
branch
4 times, most recently
from
69003d7 to
941bc4e
Compare
Gudahtt
force-pushed
the
convert-preferences-controller-to-base-controller-v2
branch
from
941bc4e to
24e158f
Compare
Gudahtt
commented
Jan 9, 2024
The `PreferencesController` has been migrated to `BaseControllerV2`. As part of this migration, the unused `name` state property has also been removed. Closes #3708
Gudahtt
force-pushed
the
convert-preferences-controller-to-base-controller-v2
branch
from
b92b379 to
e74bd82
Compare
mcmire
approved these changes
Jan 9, 2024
| * @returns A PreferencesController instance. | ||
| */ | ||
| function setupPreferencesController( | ||
| options: Partial<ConstructorParameters<typeof PreferencesController>[0]> = {}, |
There was a problem hiding this comment.
Nit: For some other controllers we have an *Options type that holds the options. Think it's worth it to extract that? I guess this is also fine too, just a bit verbose.
There was a problem hiding this comment.
Hmm, I actually find that pattern makes the code it bit harder to read. I prefer declaring options inline rather than in types declared somewhere else.
Gudahtt
deleted the
convert-preferences-controller-to-base-controller-v2
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
PreferencesControllerhas been migrated toBaseControllerV2. As part of this migration, the unusednamestate property has also been removed.References
Closes #3708
Changelog
@metamask/preferences-controllerChanged
BaseControllerV2messengerand an optionalstateproperty.Checklist