fix(base-controller): Fix stateChange subscriptions with selectors
#3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
3 tasks
Gudahtt
force-pushed
the
fix-selectors-initial-value
branch
from
23c8fa5 to
a89dd9f
Compare
Gudahtt
force-pushed
the
fix-state-change-event-selectors
branch
3 times, most recently
from
451b847 to
6e17f66
Compare
Gudahtt
force-pushed
the
fix-selectors-initial-value
branch
3 times, most recently
from
596d89a to
34a6e69
Compare
Subscribers to the `stateChange` event of any `BaseControllerV2`-based controllers will now correctly handle the initial state change event. Previously the initial state change would always result in this event firing, even for subscriptions with selectors where the selected value has not changed. Additionally, the `previousValue` returned was always set to `undefined` the first time. `BaseControllerV2` has been updated to correctly compare with the previous value even for the first state change. The returned `previousValue` is also now guaranteed to be correct even for the initial state change. Fixes #3701
Gudahtt
force-pushed
the
fix-state-change-event-selectors
branch
from
6e17f66 to
0374150
Compare
mikesposito
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Subscribers to the
stateChangeevent of anyBaseControllerV2-based controllers will now correctly handle the initial state change event.Previously the initial state change would always result in this event firing, even for subscriptions with selectors where the selected value has not changed. Additionally, the
previousValuereturned was always set toundefinedthe first time.BaseControllerV2has been updated to correctly compare with the previous value even for the first state change. The returnedpreviousValueis also now guaranteed to be correct even for the initial state change.References
Fixes #3701
Changelog
@metamask/base-controllerstateChangeevent of anyBaseControllerV2-based controllers will now correctly handle the initial state change eventpreviousValuereturned was always set toundefinedthe first time.BaseControllerV2has been updated to correctly compare with the previous value even for the first state change. The returnedpreviousValueis also now guaranteed to be correct even for the initial state change.Checklist