Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 100.0.0 #3667

Merged
merged 16 commits into from
Dec 14, 2023
Merged

Release 100.0.0 #3667

merged 16 commits into from
Dec 14, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 14, 2023

See changelogs for details

@Gudahtt Gudahtt marked this pull request as ready for review December 14, 2023 14:34
@Gudahtt Gudahtt requested a review from a team as a code owner December 14, 2023 14:34
PR #3600 included a non-breaking change to `controller-utils` that was
required by the `assets-controllers` changes.
@Gudahtt Gudahtt requested a review from a team as a code owner December 14, 2023 15:31
@Gudahtt
Copy link
Member Author

Gudahtt commented Dec 14, 2023

Note that @metamask/polling-controller has a breaking change in this release, but I have skipped releasing @metamask/gas-fee-controller and @metamask/user-operation-controller which depend on it. Typically we'd want them to be released together so that clients don't need to use two separate copies of @metamask/polling-controller, but they've been temporarily held back here to reduce the scope of this release, which we're in a rush to get out because it includes various high-priority changes. We'll temporarily deal with the extra package bloat in the clients, and follow up with a 101 release that updates those packages immediately after this one.

Edit: There is now a major @metamask/controller-utils version bump as well. Similarly to the @metamask/polling-controller changes, dependent packages have been omitted from this release to reduce scope.

- The following controllers now accept a `onNetworkDidChange` constructor option instead of a `onNetworkStateChange` option:
- `TokensController`
- `AssetsContractController`
- Update `@metamask/polling-controller` to v3 ([#3636](https://github.com/MetaMask/core/pull/3636))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adonesky1 does this sound right to you?

I noticed that that PR didn't include any change entries for this package, but it does seem to me that it at least added these underscore-prefixed methods.

@Gudahtt
Copy link
Member Author

Gudahtt commented Dec 14, 2023

@bergeron I had a question about the "make safely execute type safe" PR, I wasn';t sure if it deserved an entry here in the assets-controllers update. See here for details: #3629 (comment)

The PR description seemed to imply that it had no changes, but the diff suggested a potential minor bug fix/improvement.

Edit: I have reviewed the changes more closely, and I think I've described them accurately enough in this commit: ac487ce
Let me know what you think!

packages/assets-controllers/CHANGELOG.md Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this!

@Gudahtt Gudahtt merged commit 894122b into main Dec 14, 2023
136 checks passed
@Gudahtt Gudahtt deleted the release/100.0.0 branch December 14, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants