-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 100.0.0 #3667
Release 100.0.0 #3667
Conversation
PR #3600 included a non-breaking change to `controller-utils` that was required by the `assets-controllers` changes.
Note that Edit: There is now a major |
- The following controllers now accept a `onNetworkDidChange` constructor option instead of a `onNetworkStateChange` option: | ||
- `TokensController` | ||
- `AssetsContractController` | ||
- Update `@metamask/polling-controller` to v3 ([#3636](https://github.com/MetaMask/core/pull/3636)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adonesky1 does this sound right to you?
I noticed that that PR didn't include any change entries for this package, but it does seem to me that it at least added these underscore-prefixed methods.
@bergeron I had a question about the "make safely execute type safe" PR, I wasn';t sure if it deserved an entry here in the The PR description seemed to imply that it had no changes, but the diff suggested a potential minor bug fix/improvement. Edit: I have reviewed the changes more closely, and I think I've described them accurately enough in this commit: ac487ce |
Co-authored-by: Elliot Winkler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this!
See changelogs for details