Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic usage gas when transaction to is undefined #28

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Nov 20, 2018

This PR defines gas as '0x5208' (21000) when transaction to is undefined.

@bitpshr bitpshr merged commit 4c0e08e into master Nov 27, 2018
@bitpshr bitpshr deleted the undefined-transaction-to branch November 27, 2018 21:16
mcmire added a commit to mcmire/core that referenced this pull request Jul 17, 2023
MajorLift added a commit that referenced this pull request Sep 29, 2023
…of migration (#28)

## Description
- This PR aligns the ESLint and Prettier packages and configs in this repo with the core monorepo.
- This is a preparation step for migrating the `eth-json-rpc-provider` package into the core monorepo.
- Originally, the plan was to decrement the TypeScript version to align with the core monorepo, but following [this discussion](MetaMask/eth-json-rpc-provider#27), we've opted to use TypeScript version v4.8.4, and preserve the compiler options in this package that aren't enabled in the core monorepo.

## References
- See #1551
- Closes #1683
- Closes #1682 (is superseded by this PR)
kanthesha pushed a commit that referenced this pull request Oct 11, 2023
* update eth-json-rpc-errors

* 5.1.8
MajorLift added a commit that referenced this pull request Oct 11, 2023
…of migration (#28)

## Description
- This PR aligns the ESLint and Prettier packages and configs in this repo with the core monorepo.
- This is a preparation step for migrating the `eth-json-rpc-provider` package into the core monorepo.
- Originally, the plan was to decrement the TypeScript version to align with the core monorepo, but following [this discussion](MetaMask/eth-json-rpc-provider#27), we've opted to use TypeScript version v4.8.4, and preserve the compiler options in this package that aren't enabled in the core monorepo.

## References
- See #1551
- Closes #1683
- Closes #1682 (is superseded by this PR)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants