Bump @metamask/eth-keyring-controller from 13.0.1 to 14.0.0 #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
@dependabot recreate |
This comment was marked as resolved.
This comment was marked as resolved.
|
@dependabot recreate |
1 similar comment
|
@dependabot recreate |
legobeat
force-pushed
the
dependabot/npm_and_yarn/metamask/eth-keyring-controller-14.0.0
branch
3 times, most recently
from
8127e9e
to
a19c990
Compare
Bumps [@metamask/eth-keyring-controller](https://github.com/MetaMask/KeyringController) from 13.0.1 to 14.0.0. - [Release notes](https://github.com/MetaMask/KeyringController/releases) - [Changelog](https://github.com/MetaMask/KeyringController/blob/main/CHANGELOG.md) - [Commits](MetaMask/KeyringController@v13.0.1...v14.0.0) --- updated-dependencies: - dependency-name: "@metamask/eth-keyring-controller" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
legobeat
force-pushed
the
dependabot/npm_and_yarn/metamask/eth-keyring-controller-14.0.0
branch
from
a19c990
to
9c39d5f
Compare
mcmire
approved these changes
Oct 27, 2023
| @@ -31,7 +31,7 @@ | |||
| "dependencies": { | |||
| "@keystonehq/metamask-airgapped-keyring": "^0.13.1", | |||
| "@metamask/base-controller": "^3.2.3", | |||
| "@metamask/eth-keyring-controller": "^13.0.1", | |||
| "@metamask/eth-keyring-controller": "^14.0.0", | |||
There was a problem hiding this comment.
Just checking the dependency tree to check whether this would introduce breaking changes, and it seems that it would not. The updates seem to mainly be to unrelated parts of @metamask/utils. The bump to ethereum-cryptography could be breaking but doesn't seem that way.
Would you agree?
There was a problem hiding this comment.
Could it exacerbate the issue here? #1868
There was a problem hiding this comment.
Reflects my experience as well.
…-controller-14.0.0
…-controller-14.0.0
legobeat
deleted the
dependabot/npm_and_yarn/metamask/eth-keyring-controller-14.0.0
branch
mcmire
pushed a commit
that referenced
this pull request
Nov 2, 2023
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [@metamask/eth-keyring-controller](https://github.com/MetaMask/KeyringController) from 13.0.1 to 14.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/MetaMask/KeyringController/releases"><code>@metamask/eth-keyring-controller</code>'s releases</a>.</em></p> <blockquote> <h2>14.0.0</h2> <h3>Changed</h3> <ul> <li><strong>BREAKING:</strong> Bump <code>@metamask/eth-sig-util</code> from <code>^6.0.0</code> to <code>^7.0.0</code> (<a href="https://redirect.github.com/MetaMask/KeyringController/pull/269">#269</a>)</li> <li><strong>BREAKING:</strong> Bump <code>@metamask/eth-hd-keyring</code> from <code>^6.0.0</code> to <code>^7.0.1</code> (<a href="https://redirect.github.com/MetaMask/KeyringController/pull/275">#275</a>)</li> <li><strong>BREAKING:</strong> Bump <code>@metamask/eth-simple-keyring</code> from <code>^5.0.0</code> to <code>^6.0.0</code> (<a href="https://redirect.github.com/MetaMask/KeyringController/pull/273">#273</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/MetaMask/KeyringController/blob/main/CHANGELOG.md"><code>@metamask/eth-keyring-controller</code>'s changelog</a>.</em></p> <blockquote> <h2>[14.0.0]</h2> <h3>Changed</h3> <ul> <li><strong>BREAKING:</strong> Bump <code>@metamask/eth-sig-util</code> from <code>^6.0.0</code> to <code>^7.0.0</code> (<a href="https://redirect.github.com/MetaMask/KeyringController/pull/269">#269</a>)</li> <li><strong>BREAKING:</strong> Bump <code>@metamask/eth-hd-keyring</code> from <code>^6.0.0</code> to <code>^7.0.1</code> (<a href="https://redirect.github.com/MetaMask/KeyringController/pull/275">#275</a>)</li> <li><strong>BREAKING:</strong> Bump <code>@metamask/eth-simple-keyring</code> from <code>^5.0.0</code> to <code>^6.0.0</code> (<a href="https://redirect.github.com/MetaMask/KeyringController/pull/273">#273</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/MetaMask/KeyringController/commit/4943da5ed630cac2ab6cfa0160a5d266e60d131d"><code>4943da5</code></a> 14.0.0 (<a href="https://redirect.github.com/MetaMask/KeyringController/issues/265">#265</a>)</li> <li><a href="https://github.com/MetaMask/KeyringController/commit/4c785f490f5ae00f81e32d84e73806e7dd45aed2"><code>4c785f4</code></a> devDeps: bump <code>@metamask/eslint-config*</code> to v12 (<a href="https://redirect.github.com/MetaMask/KeyringController/issues/262">#262</a>)</li> <li><a href="https://github.com/MetaMask/KeyringController/commit/256c540cabaa39dce9bb787ac5cd9601b3f8c029"><code>256c540</code></a> deps: <code>@metamask/eth-hd-keyring</code>@^6.0.0->^7.0.1 (<a href="https://redirect.github.com/MetaMask/KeyringController/issues/275">#275</a>)</li> <li><a href="https://github.com/MetaMask/KeyringController/commit/4e4c471d441e30802e0b44c6b006f60ff3728282"><code>4e4c471</code></a> deps: <code>@metamask/eth-simple-keyring</code>@^5.0.0->^6.0.0 (<a href="https://redirect.github.com/MetaMask/KeyringController/issues/273">#273</a>)</li> <li><a href="https://github.com/MetaMask/KeyringController/commit/8d30a98176fe04072b694ede2a0dfc4b6838aafd"><code>8d30a98</code></a> Bump <code>@metamask/auto-changelog</code> from 3.2.0 to 3.3.0 (<a href="https://redirect.github.com/MetaMask/KeyringController/issues/278">#278</a>)</li> <li><a href="https://github.com/MetaMask/KeyringController/commit/24f93d9742b2b36e33b23ea3abb2de6f8f5d9088"><code>24f93d9</code></a> Bump <code>@metamask/eth-sig-util</code> from 6.0.0 to 7.0.0 (<a href="https://redirect.github.com/MetaMask/KeyringController/issues/269">#269</a>)</li> <li>See full diff in <a href="https://github.com/MetaMask/KeyringController/compare/v13.0.1...v14.0.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: legobt <[email protected]> Co-authored-by: legobeat <[email protected]>
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Bumps @metamask/eth-keyring-controller from 13.0.1 to 14.0.0.
Release notes
Sourced from
@metamask/eth-keyring-controller's releases.Changelog
Sourced from
@metamask/eth-keyring-controller's changelog.Commits
4943da514.0.0 (#265)4c785f4devDeps: bump@metamask/eslint-config*to v12 (#262)256c540deps:@metamask/eth-hd-keyring@^6.0.0->^7.0.1 (#275)4e4c471deps:@metamask/eth-simple-keyring@^5.0.0->^6.0.0 (#273)8d30a98Bump@metamask/auto-changelogfrom 3.2.0 to 3.3.0 (#278)24f93d9Bump@metamask/eth-sig-utilfrom 6.0.0 to 7.0.0 (#269)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)