Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth-json-rpc-provider migration - D: Repair breaking packages and finalize merge #1770

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Oct 4, 2023

Explanation

This PR implements the following incremental step in the process for migrating eth-json-rpc-provider into the core monorepo:


Phase D: Repair and merge

1. Repair breaking code in downstream packages

  • network-controller
  • selected-network-controller
  • transaction-controller
  • gas-fee-controller

2. Finalize merge

  • Check that all tests are passing in all subpackages of core and CI.
  • Merge packages/[package-name] directory into core main branch.

See #1551 (comment) for an outline of the entire process.

References

Changelog

@metamask/eth-json-rpc-provider

  • ADDED: Migrated into the core monorepo.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@MajorLift MajorLift requested a review from a team as a code owner October 4, 2023 00:52
@MajorLift MajorLift marked this pull request as draft October 4, 2023 00:52
@socket-security
Copy link

socket-security bot commented Oct 4, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@MajorLift MajorLift self-assigned this Oct 4, 2023
@MajorLift MajorLift changed the base branch from main to 230927-integrate-eth-json-rpc-provider October 4, 2023 00:54
@MajorLift MajorLift changed the title eth-json-rpc-provider migration - D: Repair breaking packages and merge into core repo eth-json-rpc-provider migration - D: Repair breaking packages and finalize merge Oct 4, 2023
@MajorLift MajorLift force-pushed the 231002-resolve-downstream-errors-for-eth-json-rpc-provider-migration branch 3 times, most recently from 9162c83 to 6b99e07 Compare October 4, 2023 22:52
@MajorLift MajorLift force-pushed the 231002-resolve-downstream-errors-for-eth-json-rpc-provider-migration branch from 6b99e07 to 649175d Compare October 5, 2023 16:08
@MajorLift
Copy link
Contributor Author

Consolidating into #1738

@MajorLift MajorLift closed this Oct 11, 2023
@MajorLift MajorLift deleted the 231002-resolve-downstream-errors-for-eth-json-rpc-provider-migration branch October 12, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant