-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump/deps @metamask/eth-snap-keyring @metamask/keyring-api @metamask/snaps-controllers @metamask/snaps-utils eth-rpc-errors -> @metamask/rpc-errors in AccountsController #1735
Conversation
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
bff8e0a
to
904f204
Compare
@SocketSecurity ignore @metamask/[email protected] |
…ntroller-27092023
new author ok |
…ntroller-27092023
@SocketSecurity ignore @metamask/[email protected] |
@@ -3,7 +3,8 @@ | |||
"compilerOptions": { | |||
"baseUrl": "./", | |||
"outDir": "./dist", | |||
"rootDir": "./src" | |||
"rootDir": "./src", | |||
"skipLibCheck": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring type errors from @metamask/rpc-methods
node_modules/@metamask/rpc-methods/dist/types/restricted/getLocale.d.ts:46:113 - error TS2344: Type 'void' does not satisfy the constraint 'RestrictedMethodParameters | null'.
export declare function getImplementation({ getLocale }: GetLocaleMethodHooks): (_args: RestrictedMethodOptions<void>) => Promise<string>;
Will revert once it is fixed
Explanation
Bumps the following dependencies in the AccountsController and fixes a type error introduced by a using the latest snaps controller
Changelog
@metamask/accounts-controller
Checklist