-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
queueing #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
@metamaskbot publish-preview |
replaced by #1806 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
What is the current state of things and why does it need to change?
Currently, dapps must keep track of what metamasks selected network is, and switch the network appropriately. We recently added a selectedNetworkController that keeps track of what dapp has requested what network. This PR adds some middleware that will automatically prompt the user to switch metamasks network if the saved network for the dapp doesnt match. It also adds a queue, which will cause requests which require confirmations to be processed in a first-in-first-out manner.
The queued request controller provides this api mechanism and serves as a place to interate on the queueing implementation.
The selected network controller is updated to provide a proxy provider - that is, a provider that will be swapped out based on the dapps network selections.
References
needs these
Changelog
@metamask/queued-request-controller
@metamask/selected-network-controller
Checklist