Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KeyringController message sign and encryption actions #1654

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Add KeyringController message sign and encryption actions #1654

merged 3 commits into from
Sep 8, 2023

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Sep 4, 2023 •
edited
Loading

Explanation

This PR adds actions to the KeyringController messenger to:

  • signMessage, signPersonalMessage, signTypedMessage, used by SignatureController
  • decryptMessage, getEncryptionPublicKey, used by EncryptionPublicKeyController and DecryptMessageController in the extension.

References

Changelog

@metamask/keyring-controller

  • ADDED: KeyringController messenger actions:
    • KeyringController:signMessage
    • KeyringController:signPersonalMessage
    • KeyringController:signTypedMessage
    • KeyringController:decryptMessage
    • KeyringController:getEncryptionPublicKey

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@mikesposito mikesposito requested a review from a team as a code owner September 4, 2023 13:10
@mikesposito mikesposito mentioned this pull request Sep 4, 2023
Merged
3 tasks
@mikesposito mikesposito force-pushed the feat/add-sign-actions branch 2 times, most recently from 25216b5 to c2cac86 Compare September 5, 2023 10:52
@mikesposito mikesposito changed the title Add KeyringController sign actions Add KeyringController sign actions Sep 5, 2023
@mikesposito mikesposito changed the title Add KeyringController sign actions Add KeyringController message sign and encryption actions Sep 7, 2023
@mikesposito mikesposito merged commit 0d9c184 into main Sep 8, 2023
99 checks passed
@mikesposito mikesposito deleted the feat/add-sign-actions branch September 8, 2023 07:44
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@mikesposito @MajorLift
Add KeyringController message sign and encryption actions (#1654)
79a6a5d
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@mikesposito @MajorLift
Add KeyringController message sign and encryption actions (#1654)
7e20209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikesposito @gantunesr