Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add addNewKeyring method #1594

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Add addNewKeyring method #1594

merged 1 commit into from
Aug 17, 2023

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Aug 17, 2023 •
edited
Loading

Explanation

This PR adds a addNewKeyring method to KeyringController, which can be used to add a keyring for a given type.

This method internally calls EthKeyringController.addNewKeyring.

This is needed to migrate the last interactions between the extension and EthKeyringController.

References

Changelog

@metamask/keyring-controller

  • ADDED: addNewKeyring method to add a new keyring for a given type

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@mikesposito mikesposito requested a review from a team as a code owner August 17, 2023 12:10
@mikesposito mikesposito changed the title feat: addNewKeyring method Add addNewKeyring method Aug 17, 2023
@mikesposito mikesposito mentioned this pull request Aug 17, 2023
Closed
4 tasks
Gudahtt
Gudahtt approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito merged commit 2837fcb into main Aug 17, 2023
91 checks passed
@mikesposito mikesposito deleted the feat/add-new-keyring-method branch August 17, 2023 17:41
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@mikesposito @MajorLift
Add addNewKeyring method (#1594)
24e48f7
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@mikesposito @MajorLift
Add addNewKeyring method (#1594)
baf5b87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@cryptodev-2s cryptodev-2s Awaiting requested review from cryptodev-2s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikesposito @Gudahtt