Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ipfs preferences controller #1577

Merged
merged 12 commits into from
Aug 23, 2023
Merged

Ipfs preferences controller #1577

merged 12 commits into from
Aug 23, 2023

Conversation

tommasini
Copy link
Contributor

@metamask/preferences-controller

more info here https://github.com/MetaMask/mobile-planning/issues/1162

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@tommasini tommasini requested a review from a team as a code owner August 4, 2023 11:42
@tommasini tommasini marked this pull request as draft August 4, 2023 13:08
@tommasini tommasini marked this pull request as ready for review August 4, 2023 15:24
mcmire
mcmire previously approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. There are some opportunities for improvement but they are non-blocking.

packages/assets-controllers/src/NftController.ts Outdated Show resolved Hide resolved
packages/preferences-controller/src/PreferencesController.ts Outdated Show resolved Hide resolved
@mcmire
Copy link
Contributor

mcmire commented Aug 14, 2023

@tommasini Would you mind updating the title of this PR to better reflect the change being made here? This way, if we need to locate this PR later on, it is much easier to do so.

mcmire
mcmire previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more things but they are also non-blocking!

packages/assets-controllers/src/NftController.ts Outdated Show resolved Hide resolved
packages/assets-controllers/src/NftController.ts Outdated Show resolved Hide resolved
mcmire
mcmire previously approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more things :) but again, non-blocking.

packages/controller-utils/src/constants.ts Outdated Show resolved Hide resolved
packages/preferences-controller/src/PreferencesController.test.ts Show resolved Hide resolved
mcmire
mcmire approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience 😅 This looks good!

@tommasini tommasini merged commit 35d8876 into main Aug 23, 2023
@tommasini tommasini deleted the feat/1162-ipfs branch August 23, 2023 21:20
@Gudahtt Gudahtt mentioned this pull request Aug 25, 2023
Merged
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@tommasini @MajorLift
Ipfs preferences controller (#1577)
1d0b628
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@tommasini @MajorLift
Ipfs preferences controller (#1577)
777001a
tommasini added a commit that referenced this pull request Mar 19, 2024
@tommasini
create brack for assets controller version 11-1-0, cherry picked #1577
67aa60e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommasini @mcmire