Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 68.0.0 #1561

Merged
merged 8 commits into from
Jul 28, 2023
Merged

Release 68.0.0 #1561

merged 8 commits into from
Jul 28, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jul 28, 2023

New release of message managers.

@jpuri jpuri requested a review from a team as a code owner July 28, 2023 10:29
@jpuri jpuri requested review from mcmire and Gudahtt July 28, 2023 10:30
packages/message-manager/CHANGELOG.md Outdated Show resolved Hide resolved
@jpuri jpuri requested a review from Mrtenz July 28, 2023 11:33
@jpuri jpuri requested a review from Mrtenz July 28, 2023 11:46
packages/message-manager/CHANGELOG.md Outdated Show resolved Hide resolved
@jpuri jpuri requested a review from Mrtenz July 28, 2023 14:29
Mrtenz
Mrtenz previously approved these changes Jul 28, 2023
mcmire
mcmire previously approved these changes Jul 28, 2023
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the history for packages/message-manager and don't see any changes that rely on other packages, so it seems safe to just release this package.

@mcmire mcmire dismissed their stale review July 28, 2023 17:22

Dismissing because of lint violations

@BelfordZ
Copy link
Contributor

BelfordZ commented Jul 28, 2023

We need this PR closed / merged, as its blocking our ability to release the recently merged network controller changes.

If preview builds worked, or if yarn linking worked, this wouldnt be such a big problem.

@Mrtenz
Copy link
Member

Mrtenz commented Jul 28, 2023

We need this PR closed / merged, as its blocking our ability to release the recently merged network controller changes.

If preview builds worked, or if yarn linking worked, this wouldnt be such a big problem.

What do you mean with this?

If preview builds worked

@BelfordZ
Copy link
Contributor

@Mrtenz See this issue for more info, but the TLDR is that trying to use the preview build created here does not work.

I am unable to get started on integrating the changes made to network controller into extension/mobile until either:
a) this release is completed, allowing me to create a new release that includes network controller deployment
b) preview build of network controller is working

Does that clarify things? Is there anything you need help on as it pertains to getting this release out? Is there any way we can release the network controller before this release is merged?

@mcmire
Copy link
Contributor

mcmire commented Jul 28, 2023

@BelfordZ I'll get CI passing again so we can merge this, stand by.

@mcmire mcmire merged commit d692265 into main Jul 28, 2023
@mcmire mcmire deleted the release/68.0.0 branch July 28, 2023 21:16
@BelfordZ
Copy link
Contributor

thank you @mcmire!

Unfortunately it is now the weekend on the east coast, so no progress could be made on this today. The better part of half a day for 2 of our team members was lost on this.

@mcmire
Copy link
Contributor

mcmire commented Jul 28, 2023

@BelfordZ We will make it a priority to improve preview builds next week so they can be used more smoothly.

MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Co-authored-by: Maarten Zuidhoorn <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Co-authored-by: Maarten Zuidhoorn <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants