Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to network client test functions #1310

Merged
merged 1 commit into from
May 3, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented May 3, 2023

Description

JSDoc comments have been added to functions used for the network client tests. These were copied from the extension.

Changes

None

References

This reduces the scope of #1116

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@Gudahtt Gudahtt marked this pull request as ready for review May 3, 2023 13:59
@Gudahtt Gudahtt requested a review from a team as a code owner May 3, 2023 13:59
JSDoc comments have been added to functions used for the network client
tests. These were copied from the extension.

This reduces the scope of #1116
@Gudahtt Gudahtt force-pushed the add-network-client-test-jsdoc-comments branch from e6f2a2f to b10d8be Compare May 3, 2023 14:17
@Gudahtt Gudahtt merged commit ef92af2 into main May 3, 2023
@Gudahtt Gudahtt deleted the add-network-client-test-jsdoc-comments branch May 3, 2023 14:46
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
JSDoc comments have been added to functions used for the network client
tests. These were copied from the extension.

This reduces the scope of #1116
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
JSDoc comments have been added to functions used for the network client
tests. These were copied from the extension.

This reduces the scope of #1116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants