Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make addNewAccount idempotent #1298

Merged
merged 4 commits into from
May 2, 2023
Merged

Make addNewAccount idempotent #1298

merged 4 commits into from
May 2, 2023

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented May 2, 2023 •
edited
Loading

Description

This PR adds the accountCount parameter to the addNewAccount method of the KeyringController, and uses it to make the function call idempotent.

Changes

  • BREAKING: Added accountCount: number param to addNewAccount method

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@mikesposito mikesposito marked this pull request as ready for review May 2, 2023 13:30
@mikesposito mikesposito requested a review from a team as a code owner May 2, 2023 13:30
Gudahtt
Gudahtt approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito merged commit cb69e36 into main May 2, 2023
@mikesposito mikesposito deleted the feat/addnewaccount-idempotency branch May 2, 2023 16:17
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@mikesposito @MajorLift
Make addNewAccount idempotent (#1298)
79b962c 
* feat: addNewAccount idempotent

* test: add assertion for test case

* refactor: apply review suggestions

* test: add coverage for call without accountCount
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@mikesposito @MajorLift
Make addNewAccount idempotent (#1298)
fed201e 
* feat: addNewAccount idempotent

* test: add assertion for test case

* refactor: apply review suggestions

* test: add coverage for call without accountCount
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyringController: Make addNewAccount method idempotent
2 participants
@mikesposito @Gudahtt