Update EIP-1559 compatibility during network lookup #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
update-eip-1559-compatibility-during-network-lookup
branch
2 times, most recently
from
2e7594c
to
7d1d9a6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
refresh-network-when-connection-is-reset
branch
from
c88d819
to
b319771
Compare
Gudahtt
force-pushed
the
update-eip-1559-compatibility-during-network-lookup
branch
from
7d1d9a6
to
9ad143c
Compare
3 tasks
Base automatically changed from
refresh-network-when-connection-is-reset
to
main
April 21, 2023 01:38
Gudahtt
force-pushed
the
update-eip-1559-compatibility-during-network-lookup
branch
from
9ad143c
to
92d373a
Compare
Gudahtt
commented
Apr 21, 2023
| @@ -5445,7 +5576,7 @@ describe('NetworkController', () => { | |||
|
|
|||
| await waitForStateChanges(messenger, { | |||
| propertyPath: ['networkId'], | |||
| count: 1, | |||
| count: 2, | |||
There was a problem hiding this comment.
It seems that the network ID we're checking for here was always the second state change. But the second state change was made synchronously after the first one, so the test still passed.
The EIP-1559 compatibility state is now updated during the network lookup, rather than during the provider configuration step. Closes #1203
Gudahtt
force-pushed
the
update-eip-1559-compatibility-during-network-lookup
branch
from
eb4fae4
to
4e1f13c
Compare
Merged
3 tasks
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The EIP-1559 compatibility state is now updated during the network lookup, rather than during the provider configuration step. Closes #1203
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The EIP-1559 compatibility state is now updated during the network lookup, rather than during the provider configuration step. Closes #1203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The EIP-1559 compatibility state is now updated during the network lookup, rather than during the provider configuration step. This matches the extension more closely. This check made more sense during the network lookup anyway; it's part of checking the status of the network, not of configuring the provider.
Changes
lookupNetworkwill now check the latest block and update the network details state.References
Closes #1203
Checklist