Update Yarn constraints to remove reference to project/repo name #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating the monorepo template, it was useful to revise the Yarn constraints file so that the project/repo name could be changed without having to change a bunch of references in the file. This commit brings over those revisions: * The repository URL is now used as a basis for the homepage URL and bugs URL, so it must be set appropriately (and if it is not, the user will see a suggestion in the correct format). * Additionally, the comments above each constraint have been reworded to be more consistent and understandable, and comments have been added where missing. * Finally, some pairs of constraints which test one thing for private packages and the opposite for public packages have been updated to apply to the root package vs. non-root packages where it made sense.
mcmire
changed the title
Gudahtt
reviewed
Dec 19, 2022
Gudahtt
reviewed
Dec 19, 2022
Gudahtt
reviewed
Dec 19, 2022
|
Thanks, this looks great! I had a few questions but no major concerns |
Gudahtt
reviewed
Dec 19, 2022
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
When creating the monorepo template, it was useful to revise the Yarn constraints file so that the project/repo name could be changed without having to change a bunch of references in the file. This commit brings over those revisions: * The repository URL is now used as a basis for the homepage URL and bugs URL, so it must be set appropriately (and if it is not, the user will see a suggestion in the correct format). * Additionally, the comments above each constraint have been reworded to be more consistent and understandable, and comments have been added where missing. * Finally, some pairs of constraints which test one thing for private packages and the opposite for public packages have been updated to apply to the root package vs. non-root packages where it made sense.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
When creating the monorepo template, it was useful to revise the Yarn constraints file so that the project/repo name could be changed without having to change a bunch of references in the file. This commit brings over those revisions: * The repository URL is now used as a basis for the homepage URL and bugs URL, so it must be set appropriately (and if it is not, the user will see a suggestion in the correct format). * Additionally, the comments above each constraint have been reworded to be more consistent and understandable, and comments have been added where missing. * Finally, some pairs of constraints which test one thing for private packages and the opposite for public packages have been updated to apply to the root package vs. non-root packages where it made sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the monorepo template, it was useful to revise the Yarn constraints file so that the project/repo name could be changed without having to change a bunch of references in the file. This commit brings over those revisions: