Use GH Actions for parallelism rather than Yarn #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
run-tests-individually
branch
8 times, most recently
from
581e249 to
6a56125
Compare
mcmire
changed the title
`yarn test` is a multi-package command: it really runs `yarn test` for each package in parallel using `yarn workspaces foreach`. This works fine as long as all of the tests pass. But because this command produces a lot of output, if tests fail for any package, it can be very difficult to locate the failure. (The same goes for `yarn validate:changelog`.) There are a few ways we could solve this when these commands are run locally, but it's particularly a pain point when run on CI. For this reason, this commit adjusts the GitHub Actions configuration so that we use GitHub Actions instead of Yarn to run these commands in parallel across the monorepo. This means that if tests fail for a particular package, you only see output for that package and no other package.
mcmire
force-pushed
the
run-tests-individually
branch
from
a868fc4 to
7c8adb2
Compare
|
Here is a failing build so that you can see what it looks like when tests and/or changelog validation fails: https://github.com/MetaMask/controllers/actions/runs/3716135888 (some jobs are canceled because I pushed a new commit before this was fully finished, but you get the idea) |
This reverts commit 7c8adb2.
|
Nice. Good idea. |
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
`yarn test` is a multi-package command: it really runs `yarn test` for each package in parallel using `yarn workspaces foreach`. This works fine as long as all of the tests pass. But because this command produces a lot of output, if tests fail for any package, it can be very difficult to locate the failure. (The same goes for `yarn validate:changelog`.) There are a few ways we could solve this when these commands are run locally, but it's particularly a pain point when run on CI. For this reason, this commit adjusts the GitHub Actions configuration so that we use GitHub Actions instead of Yarn to run these commands in parallel across the monorepo. This means that if tests fail for a particular package, you only see output for that package and no other package.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
`yarn test` is a multi-package command: it really runs `yarn test` for each package in parallel using `yarn workspaces foreach`. This works fine as long as all of the tests pass. But because this command produces a lot of output, if tests fail for any package, it can be very difficult to locate the failure. (The same goes for `yarn validate:changelog`.) There are a few ways we could solve this when these commands are run locally, but it's particularly a pain point when run on CI. For this reason, this commit adjusts the GitHub Actions configuration so that we use GitHub Actions instead of Yarn to run these commands in parallel across the monorepo. This means that if tests fail for a particular package, you only see output for that package and no other package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn testis a multi-package command: it really runsyarn testforeach package in parallel using
yarn workspaces foreach. This worksfine as long as all of the tests pass. But because this command produces
a lot of output, if tests fail for any package, it can be very difficult
to locate the failure. (The same goes for
yarn validate:changelog.)There are a few ways we could solve this when these commands are run
locally, but it's particularly a pain point when run on CI. For this
reason, this commit adjusts the GitHub Actions configuration so that we
use GitHub Actions instead of Yarn to run these commands in parallel
across the monorepo. This means that if tests fail for a particular
package, you only see output for that package and no other package.